lkml.org 
[lkml]   [2017]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next V2 0/5] Refine virtio-net XDP
On Mon, Jul 24, 2017 at 01:38:59PM -0700, David Miller wrote:
> From: Jason Wang <jasowang@redhat.com>
> Date: Wed, 19 Jul 2017 16:54:44 +0800
>
> > Hi:
> >
> > This series brings two optimizations for virtio-net XDP:
> >
> > - avoid reset during XDP set
> > - turn off offloads on demand
> >
> > Changes from V1:
> > - Various tweaks on commit logs and comments
> > - Use virtnet_napi_enable() when enabling NAPI on XDP set
> > - Copy the small buffer packet only if xdp_headroom is smaller than
> > required
> >
> > Please review.
>
> Series applied, thanks Jason.
>
> Michael, I gave you 4+ days to properly review this respin of this
> series. I felt that was more than sufficient time, even with an
> intervening weekend. So if you don't like that I applied this without
> your review, please be more punctual in the future.
>
> Thank you.

My bad - reviewed when I was offline and forgot to send it out.

By luck this is not a big deal:

- Patches 1-4 are good.
- Patch 5 has some problems IMO, but all it does
is try to enable a previously non-working configuration, so
it seems ok to fix it up with follow-up patches as appropriate.

--
MST

\
 
 \ /
  Last update: 2017-07-24 23:41    [W:2.038 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site