Messages in this thread | | | Subject | Re: [PATCH 1/3] irq/irq_sim: add a simple interrupt simulator framework | From | Lars-Peter Clausen <> | Date | Mon, 24 Jul 2017 09:31:44 +0200 |
| |
On 07/19/2017 02:20 PM, Bartosz Golaszewski wrote: [...] > +void irq_sim_fini(struct irq_sim *sim) > +{
Not very likely to happen in practice, but for correctness we should probably put a irq_work_sync() here for each of the IRQs to make sure that the memory associated with the irq_sim_work_ctx struct is no longer accessed and that handle_simple_irq() is not called after irq_free_descs().
> + irq_free_descs(sim->irq_base, sim->irq_count); > + kfree(sim->irqs); > +} > +EXPORT_SYMBOL_GPL(irq_sim_fini);
| |