lkml.org 
[lkml]   [2017]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] power: supply: constify attribute_group structures.
    Hi,

    On Wed, Jul 12, 2017 at 05:13:22PM +0530, Arvind Yadav wrote:
    > attribute_groups are not supposed to change at runtime. All functions
    > working with attribute_groups provided by <linux/sysfs.h> work
    > with const attribute_group. So mark the non-const structs as const.
    >
    > File size before:
    > text data bss dec hex filename
    > 2673 400 0 3073 c01 power/supply/pcf50633-charger.o
    >
    > File size After adding 'const':
    > text data bss dec hex filename
    > 2737 336 0 3073 bed power/supply/pcf50633-charger.o
    >
    > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
    > ---

    Thanks, applied to power-supply's for-next branch.

    -- Sebastian

    > drivers/power/supply/pcf50633-charger.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/power/supply/pcf50633-charger.c b/drivers/power/supply/pcf50633-charger.c
    > index b3c1873..1ad7ccc 100644
    > --- a/drivers/power/supply/pcf50633-charger.c
    > +++ b/drivers/power/supply/pcf50633-charger.c
    > @@ -254,7 +254,7 @@ static ssize_t set_chglim(struct device *dev,
    > NULL,
    > };
    >
    > -static struct attribute_group mbc_attr_group = {
    > +static const struct attribute_group mbc_attr_group = {
    > .name = NULL, /* put in device directory */
    > .attrs = pcf50633_mbc_sysfs_entries,
    > };
    > --
    > 1.9.1
    >
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2017-07-24 20:54    [W:4.293 / U:0.672 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site