Messages in this thread | | | Date | Mon, 24 Jul 2017 16:16:49 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH] perf, tools: Make build fail on JSON parse error |
| |
On Fri, Jul 21, 2017 at 05:31:59PM -0700, Sukadev Bhattiprolu wrote: > Andi Kleen [andi@firstfloor.org] wrote: > > From: Andi Kleen <ak@linux.intel.com> > > > > Today, when a JSON file fails parsing the build continues, > > but there are no json files built in, which is difficult to debug later. > > Make the build stop on a parse error instead. > > I see the problem and we were being defensive to not break the build > on architectures that don't yet have the PMU event lists. It will be > good to check build on an architecture other than x86/powerpc. > > Also, following comments may no longer be applicable?
Isn't the Andi's change only to fail in case there's a real error in process_one_file? I think you can still have empty events dir.
jirka
| |