lkml.org 
[lkml]   [2017]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 04/28] video: fbdev: sunxvr2500: constify pci_device_id.
    Date
    pci_device_id are not supposed to change at runtime. All functions
    working with pci_device_id provided by <linux/pci.h> work with
    const pci_device_id. So mark the non-const structs as const.

    File size before:
    text data bss dec hex filename
    390 552 0 942 3ae drivers/video/fbdev/sunxvr2500.o

    File size After adding 'const':
    text data bss dec hex filename
    686 256 0 942 3ae drivers/video/fbdev/sunxvr2500.o

    Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
    ---
    drivers/video/fbdev/sunxvr2500.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/video/fbdev/sunxvr2500.c b/drivers/video/fbdev/sunxvr2500.c
    index 1a05329..544465b 100644
    --- a/drivers/video/fbdev/sunxvr2500.c
    +++ b/drivers/video/fbdev/sunxvr2500.c
    @@ -220,7 +220,7 @@ static int s3d_pci_register(struct pci_dev *pdev,
    return err;
    }

    -static struct pci_device_id s3d_pci_table[] = {
    +static const struct pci_device_id s3d_pci_table[] = {
    { PCI_DEVICE(PCI_VENDOR_ID_3DLABS, 0x002c), },
    { PCI_DEVICE(PCI_VENDOR_ID_3DLABS, 0x002d), },
    { PCI_DEVICE(PCI_VENDOR_ID_3DLABS, 0x002e), },
    --
    2.7.4
    \
     
     \ /
      Last update: 2017-07-20 23:25    [W:4.552 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site