lkml.org 
[lkml]   [2017]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/3] fat: fix quoted string splits
From
Date
On Sun, 2017-07-16 at 16:46 +0300, Andy Shevchenko wrote:
> On Sat, Jul 15, 2017 at 7:18 AM, Joe Perches <joe@perches.com> wrote:
> > On Sat, 2017-07-15 at 04:20 +0300, Andy Shevchenko wrote:
> > > On Sat, Jul 15, 2017 at 2:05 AM, Carlos Palminha
> > > <CARLOS.PALMINHA@synopsys.com> wrote:
> > > > corrects quoted string split across lines, based on checkpatch.
> > >
> > > At some point you may switch
> > >
> > > fat_msg(sb, KERN_ERR, ...)
> > >
> > > to
> > >
> > > fat_fs_error(sb, ...)
> >
> > The output would be different.
>
> As much as it adds 'error, ' at the beginning of message. I can't
> consider this a bad idea.

Adding "error" to KERN_ERR output is unnecessary
and if really desired, should be done by dmesg
or equivalent.

\
 
 \ /
  Last update: 2017-07-16 17:07    [W:0.977 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site