lkml.org 
[lkml]   [2017]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 146/178] CIFS: remove bad_network_name flag
    3.16.46-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Germano Percossi <germano.percossi@citrix.com>

    commit a0918f1ce6a43ac980b42b300ec443c154970979 upstream.

    STATUS_BAD_NETWORK_NAME can be received during node failover,
    causing the flag to be set and making the reconnect thread
    always unsuccessful, thereafter.

    Once the only place where it is set is removed, the remaining
    bits are rendered moot.

    Removing it does not prevent "mount" from failing when a non
    existent share is passed.

    What happens when the share really ceases to exist while the
    share is mounted is undefined now as much as it was before.

    Signed-off-by: Germano Percossi <germano.percossi@citrix.com>
    Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
    Signed-off-by: Steve French <smfrench@gmail.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    fs/cifs/cifsglob.h | 1 -
    fs/cifs/smb2pdu.c | 5 -----
    2 files changed, 6 deletions(-)

    --- a/fs/cifs/cifsglob.h
    +++ b/fs/cifs/cifsglob.h
    @@ -873,7 +873,6 @@ struct cifs_tcon {
    bool need_reconnect:1; /* connection reset, tid now invalid */
    #ifdef CONFIG_CIFS_SMB2
    bool print:1; /* set if connection to printer share */
    - bool bad_network_name:1; /* set if ret status STATUS_BAD_NETWORK_NAME */
    __le32 capabilities;
    __u32 share_flags;
    __u32 maximal_access;
    --- a/fs/cifs/smb2pdu.c
    +++ b/fs/cifs/smb2pdu.c
    @@ -843,9 +843,6 @@ SMB2_tcon(const unsigned int xid, struct
    else
    return -EIO;

    - if (tcon && tcon->bad_network_name)
    - return -ENOENT;
    -
    unc_path = kmalloc(MAX_SHARENAME_LENGTH * 2, GFP_KERNEL);
    if (unc_path == NULL)
    return -ENOMEM;
    @@ -939,8 +936,6 @@ tcon_exit:
    tcon_error_exit:
    if (rsp->hdr.Status == STATUS_BAD_NETWORK_NAME) {
    cifs_dbg(VFS, "BAD_NETWORK_NAME: %s\n", tree);
    - if (tcon)
    - tcon->bad_network_name = true;
    }
    goto tcon_exit;
    }
    \
     
     \ /
      Last update: 2017-07-16 16:23    [W:7.499 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site