lkml.org 
[lkml]   [2017]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 012/178] USB: serial: digi_acceleport: fix OOB-event processing
    3.16.46-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johan Hovold <johan@kernel.org>

    commit 2e46565cf622dd0534a9d8bffe152a577b48d7aa upstream.

    A recent change claimed to fix an off-by-one error in the OOB-port
    completion handler, but instead introduced such an error. This could
    specifically led to modem-status changes going unnoticed, effectively
    breaking TIOCMGET.

    Note that the offending commit fixes a loop-condition underflow and is
    marked for stable, but should not be backported without this fix.

    Reported-by: Ben Hutchings <ben@decadent.org.uk>
    Fixes: 2d380889215f ("USB: serial: digi_acceleport: fix OOB data sanity
    check")
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/usb/serial/digi_acceleport.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/usb/serial/digi_acceleport.c
    +++ b/drivers/usb/serial/digi_acceleport.c
    @@ -1501,7 +1501,7 @@ static int digi_read_oob_callback(struct
    return -1;

    /* handle each oob command */
    - for (i = 0; i < urb->actual_length - 4; i += 4) {
    + for (i = 0; i < urb->actual_length - 3; i += 4) {
    opcode = buf[i];
    line = buf[i + 1];
    status = buf[i + 2];
    \
     
     \ /
      Last update: 2017-07-16 16:12    [W:2.294 / U:0.520 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site