lkml.org 
[lkml]   [2017]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 11/95] USB: iowarrior: fix NULL-deref in write
    3.2.91-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johan Hovold <johan@kernel.org>

    commit de46e56653de7b3b54baa625bd582635008b8d05 upstream.

    Make sure to verify that we have the required interrupt-out endpoint for
    IOWarrior56 devices to avoid dereferencing a NULL-pointer in write
    should a malicious device lack such an endpoint.

    Fixes: 946b960d13c1 ("USB: add driver for iowarrior devices.")
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    [bwh: Backported to 3.2: adjust context]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/usb/misc/iowarrior.c | 8 ++++++++
    1 file changed, 8 insertions(+)

    --- a/drivers/usb/misc/iowarrior.c
    +++ b/drivers/usb/misc/iowarrior.c
    @@ -809,6 +809,14 @@ static int iowarrior_probe(struct usb_in
    goto error;
    }

    + if (dev->product_id == USB_DEVICE_ID_CODEMERCS_IOW56) {
    + if (!dev->int_out_endpoint) {
    + dev_err(&interface->dev, "no interrupt-out endpoint found\n");
    + retval = -ENODEV;
    + goto error;
    + }
    + }
    +
    /* we have to check the report_size often, so remember it in the endianess suitable for our machine */
    dev->report_size = usb_endpoint_maxp(dev->int_in_endpoint);
    if ((dev->interface->cur_altsetting->desc.bInterfaceNumber == 0) &&
    \
     
     \ /
      Last update: 2017-07-16 15:58    [W:4.059 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site