Messages in this thread | | | Subject | Re: [PATCH] tpm: tpm_crb: constify acpi_device_id. | From | Jarkko Sakkinen <> | Date | Sun, 16 Jul 2017 14:24:40 +0300 |
| |
On Thu, 2017-07-06 at 23:18 +0530, Arvind Yadav wrote: > acpi_device_id are not supposed to change at runtime. All functions > working with acpi_device_id provided by <acpi/acpi_bus.h> work with > const acpi_device_id. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 4198 608 0 4806 12c6 drivers/char/tpm/tpm_crb.o > > File size After adding 'const': > text data bss dec hex filename > 4262 520 0 4782 12ae drivers/char/tpm/tpm_crb.o > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > --- > drivers/char/tpm/tpm_crb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c > index b917b9d..bf7189e 100644 > --- a/drivers/char/tpm/tpm_crb.c > +++ b/drivers/char/tpm/tpm_crb.c > @@ -665,7 +665,7 @@ static const struct dev_pm_ops crb_pm = { > SET_RUNTIME_PM_OPS(crb_pm_runtime_suspend, crb_pm_runtime_resume, NULL) > }; > > -static struct acpi_device_id crb_device_ids[] = { > +static const struct acpi_device_id crb_device_ids[] = { > {"MSFT0101", 0}, > {"", 0}, > };
Applied.
/Jarkko
| |