lkml.org 
[lkml]   [2017]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 06/11] irqchip: mips-cpu: Drop unnecessary static
    Date
    Drop static on a local variable, when the variable is initialized before
    any possible use. Thus, the static has no benefit.

    The semantic patch that fixes this problem is as follows:
    (http://coccinelle.lip6.fr/)

    // <smpl>
    @bad exists@
    position p;
    identifier x;
    type T;
    @@
    static T x@p;
    ...
    x = <+...x...+>

    @@
    identifier x;
    expression e;
    type T;
    position p != bad.p;
    @@
    -static
    T x@p;
    ... when != x
    when strict
    ?x = e;
    // </smpl>

    Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

    ---
    These patches are all independent of each other.

    drivers/irqchip/irq-mips-cpu.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff -u -p a/drivers/irqchip/irq-mips-cpu.c b/drivers/irqchip/irq-mips-cpu.c
    --- a/drivers/irqchip/irq-mips-cpu.c
    +++ b/drivers/irqchip/irq-mips-cpu.c
    @@ -154,7 +154,7 @@ asmlinkage void __weak plat_irq_dispatch
    static int mips_cpu_intc_map(struct irq_domain *d, unsigned int irq,
    irq_hw_number_t hw)
    {
    - static struct irq_chip *chip;
    + struct irq_chip *chip;

    if (hw < 2 && cpu_has_mipsmt) {
    /* Software interrupts are used for MT/CMT IPI */
    \
     
     \ /
      Last update: 2017-07-15 22:34    [W:3.419 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site