Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 13 Jul 2017 21:39:14 -0400 | From | "J. Bruce Fields" <> | Subject | Re: [PATCH][net-next] svcrdma: fix an incorrect check on -E2BIG and -EINVAL |
| |
On Thu, Jul 13, 2017 at 01:53:10PM -0400, Chuck Lever wrote: > > > On Jul 13, 2017, at 1:51 PM, Colin King <colin.king@canonical.com> wrote: > > > > From: Colin Ian King <colin.king@canonical.com> > > > > The current check will always be true and will always jump to > > err1, this looks dubious to me. I believe && should be used > > instead of ||. > > > > Detected by CoverityScan, CID#1450120 ("Logically Dead Code") > > > > Fixes: 107c1d0a991a ("svcrdma: Avoid Send Queue overflow") > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > Reviewed-by: Chuck Lever <chuck.lever@oracle.com> > > Dan reported this today, and I have a similar patch in my > "pending for-rc" series. This one works too.
Applied and merged upstream, thanks.
--b.
| ![\](/images/icornerr.gif) |