Messages in this thread | | | From | Linus Walleij <> | Date | Tue, 11 Jul 2017 16:29:19 +0200 | Subject | Re: [PATCH] ata: fix gemini Kconfig dependencies |
| |
On Mon, Jul 10, 2017 at 10:51 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> We cannot build the new ftide010 code without also building the faraday > sata bridge driver: > > drivers/ata/pata_ftide010.o: In function `pata_ftide010_probe': > pata_ftide010.c:(.text+0x2b8): undefined reference to `gemini_sata_bridge_get' > pata_ftide010.c:(.text+0x32c): undefined reference to `gemini_sata_get_muxmode' > pata_ftide010.c:(.text+0x358): undefined reference to `gemini_sata_bridge_enabled' > drivers/ata/pata_ftide010.o: In function `pata_ftide010_gemini_port_stop': > pata_ftide010.c:(.text+0x520): undefined reference to `gemini_sata_stop_bridge' > drivers/ata/pata_ftide010.o: In function `pata_ftide010_gemini_port_start': > pata_ftide010.c:(.text+0x5bc): undefined reference to `gemini_sata_start_bridge' > > This adjusts the Kconfig dependencies accordingly. > > Fixes: be4e456ed3a5 ("ata: Add driver for Faraday Technology FTIDE010") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
My intention was definately to have the bridge driver as a separate add-on as I suspect some systems use the PATA driver without the SATA bridge.
But we can definately deal with that when those users appear.
Yours, Linus Walleij
| |