lkml.org 
[lkml]   [2017]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH v1 3/8] sched/cpufreq_schedutil: make worker kthread be SCHED_DEADLINE
    On Thu, Jul 06, 2017 at 08:56:32PM -0700, Joel Fernandes wrote:

    > > @@ -3998,7 +3998,9 @@ static int __sched_setscheduler(struct task_struct *p,
    > > }
    > >
    > > if (attr->sched_flags &
    > > - ~(SCHED_FLAG_RESET_ON_FORK | SCHED_FLAG_RECLAIM))
    > > + ~(SCHED_FLAG_RESET_ON_FORK |
    > > + SCHED_FLAG_RECLAIM |
    > > + SCHED_FLAG_SPECIAL))
    > > return -EINVAL;
    >
    > I was thinking if its better to name SCHED_FLAG_SPECIAL something more
    > descriptive than "special", since it will not be clear looking at
    > other parts of the code that this is used for the frequency scaling
    > thread or that its a DL task. I was thinking since this flag is
    > specifically setup for the sugov thread frequency scaling purpose, a
    > better flag name than SPECIAL might be SCHED_FLAG_DL_FREQ_SCALE or
    > SCHED_FLAG_FREQ_SCALE. But I am Ok with whatever makes sense to do
    > here. Thanks,

    SCHED_FLAG_IM_DOING_IT_WRONG ;-)

    \
     
     \ /
      Last update: 2017-07-11 14:37    [W:2.744 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site