Messages in this thread | | | Date | Mon, 10 Jul 2017 14:37:30 -0500 | From | "Gustavo A. R. Silva" <> | Subject | Re: [PATCH] platform/x86: fujitsu-laptop: add NULL check on devm_kzalloc() return value |
| |
Hi Darren, Jonathan,
Quoting Darren Hart <dvhart@infradead.org>:
> On Fri, Jul 07, 2017 at 09:49:00AM +0930, Jonathan Woithe wrote: >> On Thu, Jul 06, 2017 at 05:19:02PM -0500, Gustavo A. R. Silva wrote: >> > Check return value from call to devm_kzalloc() >> > in order to prevent a NULL pointer dereference. >> > >> > This issue was detected using Coccinelle and the following semantic patch: >> > >> > @@ >> > expression x; >> > identifier fld; >> > @@ >> > >> > * x = devm_kzalloc(...); >> > ... when != x == NULL >> > x->fld >> > >> > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> >> >> These checks should be added in the interest of code correctness. >> devm_kzalloc() can fail (even if it's extremely unlikely in practice) so we >> should check for this. >> >> Reviewed-by: Jonathan Woithe <jwoithe@just42.net> > > Thanks Gustavo and Jonathan, > > Queued to testing. >
Glad to help. :)
Thanks -- Gustavo A. R. Silva
| |