Messages in this thread | | | Subject | Re: [PATCH 1/3] net: stmmac: Fix error handling path in 'alloc_dma_rx_desc_resources()' | From | Giuseppe CAVALLARO <> | Date | Mon, 10 Jul 2017 08:21:50 +0200 |
| |
On 7/8/2017 9:46 AM, Christophe JAILLET wrote: > If the first 'kmalloc_array' within the loop fails, we should free what > as already been allocated, as done in all other error handling path. > > Fixes: 54139cf3bb33 ("net: stmmac: adding multiple buffers for rx") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index 19bba6281dab..4322fa4a13e8 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -1498,7 +1498,7 @@ static int alloc_dma_rx_desc_resources(struct stmmac_priv *priv) > sizeof(dma_addr_t), > GFP_KERNEL); > if (!rx_q->rx_skbuff_dma) > - return -ENOMEM; > + goto err_dma; > > rx_q->rx_skbuff = kmalloc_array(DMA_RX_SIZE, > sizeof(struct sk_buff *),
| |