lkml.org 
[lkml]   [2017]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] net/mlx5: IPSec, fix 64-bit division correctly
Date
> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd@arndb.de]
> Subject: [PATCH] net/mlx5: IPSec, fix 64-bit division correctly
>
> The new IPSec offload code introduced a build error:
>
> drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_rxtx.o: In function
> `mlx5e_ipsec_build_inverse_table':
> ipsec_rxtx.c:(.text+0x556): undefined reference
>
> Another patch was added on top to fix the build error, but
> that introduced a new bug, as we now use the remainder of
> the division rather than the result.
>
> This makes it use the correct helper function instead.
>
> Fixes: 5dfd87b67cd9 ("net/mlx5: IPSec, Fix 64-bit division on 32-bit
> builds")
> Fixes: 2ac9cfe78223 ("net/mlx5e: IPSec, Add Innova IPSec offload TX data
> path")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

This is a good fix. Values are now generated correctly.
Sorry for the mixup.

Thank you Arnd!

Reviewed-by: Ilan Tayari <ilant@mellanox.com>

\
 
 \ /
  Last update: 2017-07-10 12:24    [W:0.076 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site