Messages in this thread | | | Date | Mon, 10 Jul 2017 10:44:00 +0200 | From | Maxime Ripard <> | Subject | Re: [linux-sunxi] Re: [PATCH 1/2] pinctrl: sunxi: add a missing function of A10/A20 pinctrl driver |
| |
On Fri, Jul 07, 2017 at 07:21:19AM +0800, icenowy@aosc.io wrote: > 在 2017-07-07 04:46,Maxime Ripard 写道: > > Hi, > > > > On Thu, Jul 06, 2017 at 10:28:21PM +0800, Icenowy Zheng wrote: > > > The PH16 pin has a function with mux id 0x5, which is the DET pin of > > > the > > > "sim" (smart card reader) IP block. > > > > > > This function is missing both in the old A10 and A20 drivers, so it's > > > not found during the merge of these two drivers. > > > > > > Add it to the driver. As we now merged A20 pinctrl driver to the A10 > > > one, we need to only fix the A10 driver now. > > > > > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > > > > I'm not sure what you mean there. It's not mentionned in the A10 > > datasheet, and neither in the A20. Where did you get that info from? > > It's mentioned in all newest datasheets: "A10 Datasheet V1.70.pdf" and > "A20 Datasheet V1.41 20131230.pdf".
Mentionning that in the commit log would be great.
Where did you find those?
Maxime
-- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [unhandled content-type:application/pgp-signature] | |