Messages in this thread | | | Subject | Re: [PATCH v4 3/3] media: mtk-mdp: Fix mdp device tree | From | Hans Verkuil <> | Date | Wed, 7 Jun 2017 11:11:09 +0200 |
| |
On 07/06/17 11:07, Matthias Brugger wrote: > > > On 07/06/17 10:56, Hans Verkuil wrote: >> On 07/06/17 10:44, Matthias Brugger wrote: >>> Hi Hans, hi Mauro, >>> >>> On 23/05/17 05:24, Minghsiu Tsai wrote: >>>> From: Daniel Kurtz <djkurtz@chromium.org> >>>> >>>> If the mdp_* nodes are under an mdp sub-node, their corresponding >>>> platform device does not automatically get its iommu assigned properly. >>>> >>>> Fix this by moving the mdp component nodes up a level such that they are >>>> siblings of mdp and all other SoC subsystems. This also simplifies the >>>> device tree. >>>> >>>> Although it fixes iommu assignment issue, it also break compatibility >>>> with old device tree. So, the patch in driver is needed to iterate over >>>> sibling mdp device nodes, not child ones, to keep driver work properly. >>>> >>>> Signed-off-by: Daniel Kurtz <djkurtz@chromium.org> >>>> Signed-off-by: Minghsiu Tsai <minghsiu.tsai@mediatek.com> >>>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com> >>>> >>> >>> Are you OK to take this patch, or do you have any further comments? >> >> Nope, it's all good. Queued for 4.13. >> > > Thanks! > > I queued the other two in v4.12-next/dts64
Media bindings normally go through the media subsystem, but you've taken that one as well? I need to know, because then I drop it in my tree.
Regards,
Hans
| |