lkml.org 
[lkml]   [2017]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3] drm/bridge: Build the panel wrapper in drm_kms_helper
From
Date


On 06/06/2017 11:22 PM, Eric Anholt wrote:
> Maarten Lankhorst <maarten.lankhorst@linux.intel.com> writes:
>
>> This fixes the following depmod error when building drm as a module:
>> depmod: ERROR: Found 6 modules in dependency cycles!
>> depmod: ERROR: Cycle detected: drm -> drm_kms_helper -> drm
>>
>> Fixes: 13dfc0540a57 ("drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.")
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>
> Looks plausible to me. Given how much trouble I've had getting the
> kbuild right, anyone else want to chime in?
>

The fix looks good to me too. depmod doesn't complain after this patch.

I can queue it to drm-misc-next if no one else has any comments on it
in the next few hours or so.

I'll make sure I check with 'make module_install' before pushing, I didn't
know depmod wasn't called otherwise.

Thanks,
Archit

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

\
 
 \ /
  Last update: 2017-06-12 01:01    [W:0.114 / U:1.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site