Messages in this thread | | | Date | Wed, 7 Jun 2017 09:31:42 +0200 | From | Boris Brezillon <> | Subject | Re: [PATCHv2] mtd: nand: fsl_ifc: fix handing of bit flips in erased pages |
| |
On Thu, 1 Jun 2017 15:21:15 +0200 Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> On Thu, 1 Jun 2017 15:12:32 +0200 > Pavel Machek <pavel@ucw.cz> wrote: > > > On Thu 2017-06-01 01:09:17, Darwin Dingel wrote: > > > Hi Pavel, > > > > > > Just a minor thing. Sorry about the late comment. > > > > > > On 01/06/17 08:59, Pavel Machek wrote: > > > > + > > > > + res = check_erased_page(chip, buf); > > > > + return res; > > > > + } > > > > > > Can we just remove 'res' and change this line to: > > > return check_erased_page(chip, buf); > > > > Well... I originally had a printk there, and yes, it can be > > simplified. I can roll v3, if required, but I'd leave it as is -- it > > is still convenient place to add debugging to. > > I can fix it when applying, no need to send a new version.
Applied.
Thanks,
Boris
| |