lkml.org 
[lkml]   [2017]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 104/250] ite-cir: initialize use_demodulator before using it
    Date
    From: Nicolas Iooss <nicolas.iooss_linux@m4x.org>

    commit 7ec03e60ef81c19b5d3a46dd070ee966774b860f upstream.

    Function ite_set_carrier_params() uses variable use_demodulator after
    having initialized it to false in some if branches, but this variable is
    never set to true otherwise.

    This bug has been found using clang -Wsometimes-uninitialized warning
    flag.

    Fixes: 620a32bba4a2 ("[media] rc: New rc-based ite-cir driver for
    several ITE CIRs")

    Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
    Signed-off-by: Willy Tarreau <w@1wt.eu>
    ---
    drivers/media/rc/ite-cir.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/media/rc/ite-cir.c b/drivers/media/rc/ite-cir.c
    index 63b4225..7a754ec 100644
    --- a/drivers/media/rc/ite-cir.c
    +++ b/drivers/media/rc/ite-cir.c
    @@ -263,6 +263,8 @@ static void ite_set_carrier_params(struct ite_dev *dev)

    if (allowance > ITE_RXDCR_MAX)
    allowance = ITE_RXDCR_MAX;
    +
    + use_demodulator = true;
    }
    }

    --
    2.8.0.rc2.1.gbe9624a
    \
     
     \ /
      Last update: 2017-06-12 01:16    [W:2.491 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site