Messages in this thread | | | Date | Mon, 5 Jun 2017 15:49:43 +0300 | From | Leon Romanovsky <> | Subject | Re: [PATCH V5] rxe: Fix a sleep-in-atomic bug in post_one_send |
| |
On Mon, Jun 05, 2017 at 08:23:40PM +0800, Jia-Ju Bai wrote: > The driver may sleep under a spin lock, and the function call path is: > post_one_send (acquire the lock by spin_lock_irqsave) > init_send_wqe > copy_from_user --> may sleep > > There is no flow that makes "qp->is_user" true, and copy_from_user may > cause bug when a non-user pointer is used. So the lines of copy_from_user > and check of "qp->is_user" are removed. > > Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com> > ---
Thanks, Reviewed-by: Leon Romanovsky <leonro@mellanox.com> [unhandled content-type:application/pgp-signature] | |