lkml.org 
[lkml]   [2017]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V1] regulator: core: Fix voltage change propagations to supply regulators
From
Date
Mark,

Could you please take a look and provide any feedback.

Thanks
Tirupathi Reddy

On 5/25/2017 3:33 PM, Tirupathi Reddy wrote:
> Some regulators support get_voltage and some support get_voltage_sel
> operations. Do voltage change propagation only when the current
> regulator has a minimum dropout voltage specified or if the current
> regulator lacks both get_voltage and get_voltage_sel operations.
>
> Signed-off-by: Tirupathi Reddy <tirupath@codeaurora.org>
> ---
> drivers/regulator/core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index c0d9ae8..9fecbd4 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -2938,7 +2938,8 @@ static int regulator_set_voltage_unlocked(struct regulator *regulator,
> if (rdev->supply &&
> regulator_ops_is_valid(rdev->supply->rdev,
> REGULATOR_CHANGE_VOLTAGE) &&
> - (rdev->desc->min_dropout_uV || !rdev->desc->ops->get_voltage)) {
> + (rdev->desc->min_dropout_uV || !(rdev->desc->ops->get_voltage ||
> + rdev->desc->ops->get_voltage_sel))) {
> int current_supply_uV;
> int selector;
>

\
 
 \ /
  Last update: 2017-06-12 00:19    [W:0.080 / U:0.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site