Messages in this thread | | | Date | Mon, 5 Jun 2017 07:33:00 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures |
| |
On Sun, Jun 04, 2017 at 05:59:06PM +0300, Sagi Grimberg wrote: >> +struct nvme_ns_identifier_hdr { >> + __u8 nidt; >> + __u8 nidl; >> + __le16 reserved; >> +}; > > Nit: _hdr is usually associated with a message or alike. > > Maybe nvme_ns_id_desc is more consistent with the spec language.
The descriptor itself includes the actual value, that's why I suggested adding the _hdr prefix. But I'm fine going either way.
| |