Messages in this thread | | | Date | Fri, 30 Jun 2017 15:34:03 -0500 | From | "Gustavo A. R. Silva" <> | Subject | Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe() |
| |
Quoting Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>:
> On 06/30/2017 10:46 PM, Gustavo A. R. Silva wrote: > >>>>>> Print error message and propagate the return value of >>>>>> platform_get_irq on failure. >>>>> >>>>> You should have probably mentioned that this function no longer >>>>> returns 0 >>>>> on error. >>>> >>>> Yeah, the patches looks good to me but I'd really appreciate more >>>> context in the changelogs. Gustavo, can you please respin the >>>> patches? >>>> >>> >>> Absolutely. >>> >>> What do you think about the following changelog: >>> >>> platform_get_irq() returns an error code, but the sata_rcar driver >>> ignores it and always returns -EINVAL. This is not correct, and >>> prevents -EPROBE_DEFER from being propagated properly. >>> >>> Print error message and propagate the return value of platform_get_irq >>> on failure. Also, with this change function sata_rcar_probe() no longer >>> returns 0 on error. >>> >> >> Errata, this would be final the chagelog: >> >> platform_get_irq() returns an error code, but the sata_rcar driver >> ignores it and always returns -EINVAL. This is not correct, and >> prevents -EPROBE_DEFER from being propagated properly. Also, >> notice that platform_get_irq() no longer returns 0 on error. >> >> Print error message and propagate the return value of platform_get_irq >> on failure. > > Now I'm OK with that. >
Great :)
Thank you -- Gustavo A. R. Silva
| |