Messages in this thread Patch in this message | | | Date | Fri, 30 Jun 2017 06:10:11 -0700 | From | tip-bot for Arvind Yadav <> | Subject | [tip:smp/hotplug] cpu/hotplug: Constify attribute_group structures |
| |
Commit-ID: 993647a293814dd47ae41d38657fda6e4ab04e33 Gitweb: http://git.kernel.org/tip/993647a293814dd47ae41d38657fda6e4ab04e33 Author: Arvind Yadav <arvind.yadav.cs@gmail.com> AuthorDate: Thu, 29 Jun 2017 17:40:47 +0530 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Fri, 30 Jun 2017 09:34:39 +0200
cpu/hotplug: Constify attribute_group structures
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by <linux/sysfs.h> work with const attribute_group.
So mark the non-const structs as const:
File size before: text data bss dec hex filename 12582 15361 20 27963 6d3b kernel/cpu.o
File size After adding 'const': text data bss dec hex filename 12710 15265 20 27995 6d5b kernel/cpu.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: anna-maria@linutronix.de Cc: bigeasy@linutronix.de Cc: boris.ostrovsky@oracle.com Cc: rcochran@linutronix.de Link: http://lkml.kernel.org/r/f9079e94e12b36d245e7adbf67d312bc5d0250c6.1498737970.git.arvind.yadav.cs@gmail.com Signed-off-by: Ingo Molnar <mingo@kernel.org> --- kernel/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/cpu.c b/kernel/cpu.c index d0f5f54..b69c058 100644 --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -1629,7 +1629,7 @@ static struct attribute *cpuhp_cpu_attrs[] = { NULL }; -static struct attribute_group cpuhp_cpu_attr_group = { +static const struct attribute_group cpuhp_cpu_attr_group = { .attrs = cpuhp_cpu_attrs, .name = "hotplug", NULL @@ -1661,7 +1661,7 @@ static struct attribute *cpuhp_cpu_root_attrs[] = { NULL }; -static struct attribute_group cpuhp_cpu_root_attr_group = { +static const struct attribute_group cpuhp_cpu_root_attr_group = { .attrs = cpuhp_cpu_root_attrs, .name = "hotplug", NULL
| |