Messages in this thread | | | Date | Tue, 27 Jun 2017 08:29:17 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: 答复 : [RFC PATCH] char: misc: Init misc->list in a safe way |
| |
A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail?
A: No. Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Tue, Jun 27, 2017 at 02:02:13AM +0000, Zhongping Tan (谭中平) wrote: > Ok, firstly we need to discuss the list usage, for list head we need > do initialization, but for list node we don't need initialization at > all.
I don't understand, why is your misc driver touching that field at all? Do I need to go and make it "private" somehow?
> And for misc_list head, we use LIST_HEAD to define and initialize > it. So I don't know why we put INIT_LIST_HEAD(&misc->list) in function > misc_register, any bugs when without it?
Again, what is wrong with the code today? What driver is this causing problems for?
thanks,
greg k-h
| |