lkml.org 
[lkml]   [2017]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
On Thu, Jun 22, 2017 at 09:47:46AM +0200, Jiri Slaby wrote:
> On 06/14/2017, 03:27 PM, Josh Poimboeuf wrote:
> > I agree with all your comments, will fix them all. Thanks for the
> > review.
>
> This is not the correct way:
> ++ if (flags & O_WRONLY)
> ++ cmd = ELF_C_WRITE;
> ++ else if (flags & O_RDWR)
> ++ cmd = ELF_C_RDWR;
> ++ else
> ++ cmd = ELF_C_READ_MMAP;
>
> For this particular codeflow, it works, but it should be:
> (flags & O_ACCMODE) == O_WRONLY
> == O_RDWR

Ok, thanks. I see you started reviewing v2 early ;-) It's almost ready
to post, will send the patches next week.

--
Josh

\
 
 \ /
  Last update: 2017-06-22 20:02    [W:0.042 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site