lkml.org 
[lkml]   [2017]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 025/119] crypto: asymmetric_keys - handle EBUSY due to backlog correctly
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Gilad Ben-Yossef <gilad@benyossef.com>

    commit e68368aed56324e2e38d4f6b044bb8cf82077fc2 upstream.

    public_key_verify_signature() was passing the CRYPTO_TFM_REQ_MAY_BACKLOG
    flag to akcipher_request_set_callback() but was not handling correctly
    the case where a -EBUSY error could be returned from the call to
    crypto_akcipher_verify() if backlog was used, possibly casuing
    data corruption due to use-after-free of buffers.

    Resolve this by handling -EBUSY correctly.

    Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    crypto/asymmetric_keys/public_key.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/crypto/asymmetric_keys/public_key.c
    +++ b/crypto/asymmetric_keys/public_key.c
    @@ -140,7 +140,7 @@ int public_key_verify_signature(const st
    * signature and returns that to us.
    */
    ret = crypto_akcipher_verify(req);
    - if (ret == -EINPROGRESS) {
    + if ((ret == -EINPROGRESS) || (ret == -EBUSY)) {
    wait_for_completion(&compl.completion);
    ret = compl.err;
    }

    \
     
     \ /
      Last update: 2017-06-12 20:55    [W:6.326 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site