lkml.org 
[lkml]   [2017]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] f2fs: Fix a return value in case of error in 'f2fs_fill_super'
From
Date
On 2017/6/11 15:21, Christophe JAILLET wrote:
> err must be set to -ENOMEM, otherwise we return 0.
>
> Fixes: a912b54d3aaa0 ("f2fs: split bio cache")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,

> ---
> fs/f2fs/super.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 5be27eacea99..38f1624ac5dc 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -1976,8 +1976,10 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent)
>
> sbi->write_io[i] = kmalloc(n * sizeof(struct f2fs_bio_info),
> GFP_KERNEL);
> - if (!sbi->write_io[i])
> + if (!sbi->write_io[i]) {
> + err = -ENOMEM;
> goto free_options;
> + }
>
> for (j = HOT; j < n; j++) {
> init_rwsem(&sbi->write_io[i][j].io_rwsem);
>

\
 
 \ /
  Last update: 2017-06-12 13:00    [W:0.053 / U:0.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site