Messages in this thread | | | From | Alexey Brodkin <> | Subject | Re: [PATCH v4 05/10] drm: arc: Use crtc->mode_valid() callback | Date | Mon, 22 May 2017 18:32:02 +0000 |
| |
Hi Jose,
The only nitpicking note from my side is patch name.
Probably full driver name as "arcpgu" might give a bit more context especially if later something else from ARC appears in "drm" folder. But IMHO that doesn't worth another respin.
On Fri, 2017-05-19 at 01:52 +0100, Jose Abreu wrote: > Now that we have a callback to check if crtc supports a given mode > we can use it in arcpgu so that we restrict the number of probbed > modes to the ones we can actually display. > > This is specially useful because arcpgu crtc is responsible to set > a clock value in the commit() stage but unfortunatelly this clock > does not support all the needed ranges. > > Also, remove the atomic_check() callback as mode_valid() callback > will be called before. > > Signed-off-by: Jose Abreu <joabreu@synopsys.com> > Cc: Carlos Palminha <palminha@synopsys.com> > Cc: Alexey Brodkin <abrodkin@synopsys.com>
Reviewed-by: Alexey Brodkin <abrodkin@synopsys.com> | |