Messages in this thread | | | Subject | Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency | From | Jan Kiszka <> | Date | Mon, 22 May 2017 19:18:14 +0200 |
| |
On 2017-05-22 19:12, Andy Shevchenko wrote: > On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: >> Avoids reimplementation of DMI matching in intel_quark_i2c_setup. > > What's wrong with current approach? I suppose this will make sense > when we will have an issue / impediment. Right now it looks like > over-engineering. > > (Yes, I know what I said to you about this earlier, OTOH see above) >
It allows matching on additional DMI tags without additional code - patch 2 depends on it.
Jan
-- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux
| |