Messages in this thread Patch in this message | | | Subject | [PATCH 5/5] sctp: Adjust one function call together with a variable assignment | From | SF Markus Elfring <> | Date | Mon, 22 May 2017 18:41:45 +0200 |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Mon, 22 May 2017 18:15:12 +0200
The script "checkpatch.pl" pointed information out like the following.
ERROR: do not use assignment in if condition
Thus fix the affected source code place.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- net/sctp/protocol.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c index 057479b7bd72..be2fe3ebae78 100644 --- a/net/sctp/protocol.c +++ b/net/sctp/protocol.c @@ -141,7 +141,8 @@ static void sctp_v4_copy_addrlist(struct list_head *addrlist, struct sctp_sockaddr_entry *addr; rcu_read_lock(); - if ((in_dev = __in_dev_get_rcu(dev)) == NULL) { + in_dev = __in_dev_get_rcu(dev); + if (!in_dev) { rcu_read_unlock(); return; } -- 2.13.0
| |