Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH] libertas: Avoid reading past end of buffer | Date | Thu, 11 May 2017 06:45:58 +0300 |
| |
Joe Perches <joe@perches.com> writes:
> unrelated trivia: > > lbs_deb_enter is used incorrectly here at > function exit as both enter and leave calls. > > That type of copy/paste defect may be common. > > $ git grep -w lbs_deb_enter | wc -l > 148 > $ git grep -w lbs_deb_leave | wc -l > 71 > > One would expect these numbers to be the same. > > Another option would be to delete all these > calls as ftrace function tracing works well.
Yeah, deleting all the enter/exit calls would be better.
-- Kalle Valo
| |