lkml.org 
[lkml]   [2017]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.10 13/62] net/packet: fix overflow in check for tp_reserve
    Date
    4.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Andrey Konovalov <andreyknvl@google.com>


    [ Upstream commit bcc5364bdcfe131e6379363f089e7b4108d35b70 ]

    When calculating po->tp_hdrlen + po->tp_reserve the result can overflow.

    Fix by checking that tp_reserve <= INT_MAX on assign.

    Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
    Acked-by: Eric Dumazet <edumazet@google.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/packet/af_packet.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/net/packet/af_packet.c
    +++ b/net/packet/af_packet.c
    @@ -3644,6 +3644,8 @@ packet_setsockopt(struct socket *sock, i
    return -EBUSY;
    if (copy_from_user(&val, optval, sizeof(val)))
    return -EFAULT;
    + if (val > INT_MAX)
    + return -EINVAL;
    po->tp_reserve = val;
    return 0;
    }

    \
     
     \ /
      Last update: 2017-05-01 23:48    [W:2.569 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site