Messages in this thread | | | Date | Mon, 1 May 2017 18:02:51 +0200 | From | Maxime Ripard <> | Subject | Re: [PATCH v3 1/5] clk: sunxi-ng: Add sun4i/sun7i CCU driver |
| |
Hi Priit,
Almost good, thanks!
On Wed, Apr 26, 2017 at 10:32:21PM +0300, Priit Laes wrote: > +/* TODO: GPS CLK 0x0d0 */
You should still create a define in the header for this one.
> +/* Following only exist on sun7i-a20 */ > +#define CLK_MBUS 165 > +#define CLK_HDMI1_SLOW 166 > +#define CLK_HDMI1 167 > +#define CLK_OUT_A 168 > +#define CLK_OUT_B 169
Wouldn't it be better to simply create a new A20-only header that would include the A10's and add the A20 specific clocks on top?
Thanks! Maxime
-- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [unhandled content-type:application/pgp-signature] | |