lkml.org 
[lkml]   [2017]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v23 06/11] clocksource: arm_arch_timer: refactor MMIO timer probing.
On Sat, Apr 01, 2017 at 01:51:00AM +0800, fu.wei@linaro.org wrote:
> + arch_timer_mem_freq = arch_timer_mem_get_cntfrq(base);
> + if (!arch_timer_rate && arch_timer_mem_freq) {
> + arch_timer_rate = arch_timer_mem_freq;
> + } else if (!arch_timer_rate || arch_timer_rate != arch_timer_mem_freq) {
> + pr_err(FW_BUG "invalid MMIO frequency.\n");
> + iounmap(base);
> + return -EINVAL;
> + }

I thought I had previously mentioned that this last check has the
potential to break DT systems, which may be inadvertently relying on the
probe order.

I agree we must do this check for ACPI, but I think that for DT it needs
to be relaxed.

I'm happy to rework that locally, if you can address my comments on
patch 9.

Thanks,
Mark.

\
 
 \ /
  Last update: 2017-04-05 20:43    [W:0.173 / U:0.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site