lkml.org 
[lkml]   [2017]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCHv2 7/8] printk: add printk emergency_mode parameter
On (04/03/17 17:29), Petr Mladek wrote:
[..]
> > +module_param_cb(emergency_mode,
> > + &printk_kthread_disabled_ops,
> > + &printk_kthread_disabled,
> > + 0644);
> > +MODULE_PARM_DESC(emergency_mode,
> > + "don't offload message printing to printk kthread");
>
> I wonder if we could make this easier. Something like:
>
> static bool printk_force_emergency;
> module_param_named(force_emergency, printk_force_emergency,
> bool, S_IRUGO | S_IWUSR);

yes, can do. thanks.

> and use it instead of printk_kthread_disabled variable. It was
> confusing anyway. You already mentioned that it did not
> stop the kthread.

yeah, I didn't like the `printk_kthread_disabled' naming, but
at the same time didn't feel like having `printk_emergency' and
`printk_forced_emergency'. will take a look.

-ss

\
 
 \ /
  Last update: 2017-04-04 10:30    [W:0.049 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site