lkml.org 
[lkml]   [2017]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [RFC 4/8] p2pmem: Add debugfs "stats" file


On 04/04/17 04:46 AM, Sagi Grimberg wrote:
>
>> + p2pmem_debugfs_root = debugfs_create_dir("p2pmem", NULL);
>> + if (!p2pmem_debugfs_root)
>> + pr_info("could not create debugfs entry, continuing\n");
>> +
>
> Why continue? I think it'd be better to just fail it.

Yup, agreed. This should probably also be PTR_ERR as well.

> Besides, this can be safely squashed into patch 1.

Sure, the only real reason I kept it separate was it was authored by
Steve Wise.

Logan

\
 
 \ /
  Last update: 2017-04-04 19:26    [W:1.961 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site