lkml.org 
[lkml]   [2017]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCHv2 8/8] printk: enable printk offloading
On (04/03/17 17:42), Petr Mladek wrote:
> > +/*
> > + * Init printk kthread at late_initcall stage, after core/arch/device/etc.
> > + * initialization.
> > + */
> > +static int __init init_printk_kthread(void)
> > +{
> > + struct task_struct *thread;
> > +
> > + thread = kthread_run(printk_kthread_func, NULL, "printk");
> > + if (IS_ERR(thread)) {
> > + pr_err("printk: unable to create printing thread\n");
> > + return PTR_ERR(thread);
> > + }
> > +
> > + printk_kthread = thread;
> > + return 0;
> > +}
> > +late_initcall(init_printk_kthread);
>
> I like the simplicity. I just wonder if people on tiny devices might
> want to disable it. In each case, it does not make sense on non-SMP
> machines or when people force the emergency mode all the time.
>
> I am not sure what is the practice here. I wonder if we should be
> proactive or keep it as is and wait until anyone complains. IMHO,
> it is not that big deal but...

I tend to agree that this is not a big deal, as of now.
I've bigger concerns.

-ss

\
 
 \ /
  Last update: 2017-04-04 14:23    [W:0.167 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site