Messages in this thread | | | Date | Thu, 27 Apr 2017 09:04:36 +0200 | From | Maxime Ripard <> | Subject | Re: [PATCH v2] clk: sunxi-ng: Fix dependency on SUNXI_CCU_GATE |
| |
On Wed, Apr 26, 2017 at 01:53:19PM +0200, Corentin Labbe wrote: > When CONFIG_SUNXI_CCU is set but no other SUNXI_CCU is selected i got > the following build error: > drivers/built-in.o: In function `ccu_pll_notifier_cb': > drivers/clk/sunxi-ng/ccu_common.c:71: undefined reference to `ccu_gate_helper_disable' > drivers/clk/sunxi-ng/ccu_common.c:73: undefined reference to `ccu_gate_helper_enable' > > The problem is the function ccu_pll_notifier_cb in ccu_common.c need > some function from ccu_gate.c which is not compiled since SUNXI_CCU_GATE > is not selected. > > This patch remove SUNXI_CCU_GATE and compile ccu_gate.c unconditionnaly > since all other combination of options select SUNXI_CCU_GATE finally. > > Fixes: 02ae2bc6febd ("clk: sunxi-ng: Add clk notifier to gate then ungate PLL clocks") > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
I think Chen-Yu had some comments that you didn't address.
Maxime
-- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [unhandled content-type:application/pgp-signature] | |