Messages in this thread Patch in this message | | | Subject | Re: [PATCH 4/7] staging: rtl8723bs: Move braces to same line as conditional | From | Joe Perches <> | Date | Thu, 27 Apr 2017 17:27:31 -0700 |
| |
On Thu, 2017-04-27 at 19:22 -0500, Larry Finger wrote: > On 04/27/2017 07:09 PM, Justin Vreeland wrote: > > Signed-off-by: Justin Vreeland <justin@jvreeland.com> > > --- > > drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 15 +++++---------- > > drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 9 +++------ > > drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 6 ++---- [] > Fix the over-long lines and add a commit message.
Lines with 35+ long identifiers should probably stay > 80 columns
> > diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c [] > > @@ -459,8 +458,7 @@ static int phy_BB8723b_Config_ParaFile(struct adapter *Adapter) > > Adapter->registrypriv.RegEnableTxPowerLimit == 1 || > > (Adapter->registrypriv.RegEnableTxPowerLimit == 2 && pHalData->EEPROMRegulatory == 1) > > ) { > > - if (PHY_ConfigRFWithPowerLimitTableParaFile(Adapter, pszRFTxPwrLmtFile) == _FAIL) > > - { > > + if (PHY_ConfigRFWithPowerLimitTableParaFile(Adapter, pszRFTxPwrLmtFile) == _FAIL) { > > if (HAL_STATUS_SUCCESS != ODM_ConfigRFWithHeaderFile(&pHalData->odmpriv, CONFIG_RF_TXPWR_LMT, (ODM_RF_RADIO_PATH_E)0)) > > rtStatus = _FAIL; > > }
| |