Messages in this thread | | | Date | Thu, 27 Apr 2017 16:25:34 +0200 | From | Anatolij Gustschin <> | Subject | Re: [PATCH v2] gpiolib: Add stubs for gpiod lookup table interface |
| |
On Thu, 27 Apr 2017 17:07:23 +0300 Andy Shevchenko andy.shevchenko@gmail.com wrote:
>On Thu, Apr 27, 2017 at 9:52 AM, Anatolij Gustschin <agust@denx.de> wrote: >> Add stubs for gpiod_add_lookup_table() and gpiod_remove_lookup_table() >> for the !GPIOLIB case to prevent build errors. Also add prototypes. >> >> Signed-off-by: Anatolij Gustschin <agust@denx.de> >> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > >Oh, has to take my tag back. See below why. > > >> --- a/include/linux/gpio/consumer.h >> +++ b/include/linux/gpio/consumer.h > >It is already defined in machine.h. > >What you basically need is to add stubs for !GPIOLIB case > >#ifdef ... >...existing prototypes... >#else /* GPIOLIB */ >static inline void gpiod_add_lookup_table(struct gpiod_lookup_table *table) {} >static inline void gpiod_remove_lookup_table(struct gpiod_lookup_table >*table) {} >#endif /* !GPIOLIB */ > >P.S. please notice how I put the stubs. It would be good to keep them >in two lines.
this will exceed 80 char line limit.
Thanks,
Anatolij
| |