Messages in this thread | | | Date | Thu, 27 Apr 2017 11:57:16 +0200 | From | Greg KH <> | Subject | Re: [PATCH, 3.18-stable regression] gadgetfs: fix uninitialized variable in error handling |
| |
On Fri, Apr 21, 2017 at 03:06:12PM +0200, Arnd Bergmann wrote: > gcc warns about a bug in 3.18.y: > > drivers/usb/gadget/legacy/inode.c:648:10: warning: 'value' may be used > > This is caused by the backport of f01d35a15fa0416 from 4.0 to 3.18: > c81fc59be42c6e0 gadgetfs: use-after-free in ->aio_read() > > The backported patch was buggy, but the mainline code was rewritten > in a larger patch directly following this one in a way that fixed the > bug. > > For stable, we should need only a one-line change to make sure we > return an proper error code. It is very unlikely that anybody ever > ran into the out-of-memory case here in practice, but the compiler > is right in theory. > > Fixes: c81fc59be42c ("gadgetfs: use-after-free in ->aio_read()") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/usb/gadget/legacy/inode.c | 1 + > 1 file changed, 1 insertion(+)
Now queued up, thanks!
greg k-h
| |