Messages in this thread | | | From | "Gao, Bin" <> | Subject | RE: [PATCH v2 1/1] gpio: gpio-wcove: fix GPIO IRQ status mask | Date | Wed, 26 Apr 2017 16:42:02 +0000 |
| |
On Wed, April 26, 2017 at 7:26 AM, Linus Walleij wrote: >On Mon, Apr 24, 2017 at 9:15 PM, ><sathyanarayanan.kuppuswamy@linux.intel.com> wrote: > >> From: Kuppuswamy Sathyanarayanan >> <sathyanarayanan.kuppuswamy@linux.intel.com> >> >> According to Whiskey Cove PMIC spec, bit 7 of GPIOIRQ0_REG belongs to >> battery IO. So we should skip this bit when checking for GPIO IRQ >> pending status. Otherwise, wcove_gpio_irq_handler() might go into the >> infinite loop until IRQ "pending" status becomes 0. This patch fixes this issue. >> >> Signed-off-by: Kuppuswamy Sathyanarayanan >> <sathyanarayanan.kuppuswamy@linux.intel.com> > >Looks fine to me, tentatively applied. > >Bin, Mika, Andy, OK? > >Yours, >Linus Walleij
Looks reasonable to me.
Thanks, Bin
| |