lkml.org 
[lkml]   [2017]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 20/22] tools arch: Sync arch/x86/lib/memcpy_64.S with the kernel
    From
    Date
    On Tue, 2017-04-25 at 16:18 +0000, Luck, Tony wrote:
    > > > If we are going to have all these copies of kernel files below
    > > > "tools/...", perhaps checkpatch could warn people touching one
    > > > that the other needs the same update?
    > >
    > > How would checkpatch know tools hasn't already updated the other?
    >
    > If checkpatch had a list of all the tools copies, it could warn if a patch
    > touched a file without touching the copy.

    I rather doubt these files are modified simultaneously.

    A quick and no doubt incomplete git log -- "tools/*/kernel.h"
    seems to show little simultaneity.

    > Not completely ideal because people might update the two files in
    > separate patches in a series (in which case they would see warnings
    > from both patches).
    >
    > Also means that checkpatch needs the list of copied files ... not sure
    > how often that changes.

    Nor I. Anyway, feel free to propose an actual patch.

    \
     
     \ /
      Last update: 2017-04-25 18:28    [W:3.751 / U:0.688 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site