lkml.org 
[lkml]   [2017]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 10/20] fuse: set mapping error in writepage_locked when it fails
    On Mon 24-04-17 09:22:49, Jeff Layton wrote:
    > This ensures that we see errors on fsync when writeback fails.
    >
    > Signed-off-by: Jeff Layton <jlayton@redhat.com>

    Hum, but do we really want to clobber mapping errors with temporary stuff
    like ENOMEM? Or do you want to handle that in mapping_set_error?

    Honza

    > ---
    > fs/fuse/file.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/fs/fuse/file.c b/fs/fuse/file.c
    > index ec238fb5a584..07d0efcb050c 100644
    > --- a/fs/fuse/file.c
    > +++ b/fs/fuse/file.c
    > @@ -1669,6 +1669,7 @@ static int fuse_writepage_locked(struct page *page)
    > err_free:
    > fuse_request_free(req);
    > err:
    > + mapping_set_error(page->mapping, error);
    > end_page_writeback(page);
    > return error;
    > }
    > --
    > 2.9.3
    >
    >
    --
    Jan Kara <jack@suse.com>
    SUSE Labs, CR

    \
     
     \ /
      Last update: 2017-04-24 18:06    [W:5.356 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site