Messages in this thread | | | Subject | Re: [PATCH v7 4/5] i2c: aspeed: added driver for Aspeed I2C | From | Benjamin Herrenschmidt <> | Date | Tue, 25 Apr 2017 12:21:04 +1000 |
| |
On Mon, 2017-04-24 at 11:18 -0700, Brendan Higgins wrote: > +static int __aspeed_i2c_init_clk(struct aspeed_i2c_bus *bus, > + struct platform_device *pdev) > +{
Minor nit ... I'm really not fan of those underscores.
We use __ functions in some cases in the kernel for low level helpers, usually when it's a low level variant of an existing function or an "unlocked" variant, but I don't think generalizing it to pretty much everything in the driver is worthwhile here.
If you want to be explicit about locking, I would suggest you use a comment in front of the function explaining if it expects to be called with the lock held.
We tend to only do that when *both* functions exist and one is implemented in term of the other.
Cheers, Ben.
| |