lkml.org 
[lkml]   [2017]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2/2] n2rng: Combine substrings for two messages in n2rng_probe()
    From
    Date
    On Fri, 2017-04-21 at 19:36 +0800, Herbert Xu wrote:
    > On Wed, Apr 19, 2017 at 11:11:35AM +0200, SF Markus Elfring wrote:
    > > From: Markus Elfring <elfring@users.sourceforge.net>
    > > Date: Wed, 19 Apr 2017 10:50:04 +0200
    > >
    > > The script "checkpatch.pl" pointed information out like the following.
    > >
    > > WARNING: quoted string split across lines
    > >
    > > Thus fix the affected source code places.
    > >
    > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    >
    > This patch doesn't seem to add any value so I'm not taking it.

    Your choice.

    The general reason to merge strings is in CodingStyle

    2) Breaking long lines and strings
    []
    never break user-visible strings such as
    printk messages, because that breaks the ability to grep for them.


    \
     
     \ /
      Last update: 2017-04-21 20:33    [W:7.920 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site